Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-2065] [EC2] give launched instances names #1043

Closed
wants to merge 4 commits into from
Closed

[SPARK-2065] [EC2] give launched instances names #1043

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
69da6cf
Merge pull request #1 from apache/master
nchammas Jun 10, 2014
6544b7e
[SPARK-2065] give launched instances names
nchammas Jun 10, 2014
2627247
broke up lines before they hit 100 chars
nchammas Jun 11, 2014
69f6e22
PEP8 fixes
nchammas Jun 11, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ec2/spark_ec2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,12 @@ def launch_cluster(conn, opts, cluster_name):
master_nodes = master_res.instances
print "Launched master in %s, regid = %s" % (zone, master_res.id)

# Give the instances descriptive names
for master in master_nodes:
master.add_tag(key='Name', value='spark-{cn}-master-{iid}'.format(cn=cluster_name, iid=master.id))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind wrapping this before 100 char wide? We don't yet enforce it, but we will soon enforce line length in Python as well. Also for line 425. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem! I made the change. Do you have any rules about whether the closing parenthesis should go on its own line or not?

for slave in slave_nodes:
slave.add_tag(key='Name', value='spark-{cn}-slave-{iid}'.format(cn=cluster_name, iid=slave.id))

# Return all the instances
return (master_nodes, slave_nodes)

Expand Down