Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-12145][SQL] Hive Authorization V2 interface requires the username information from SessionState #10144

Closed
wants to merge 3 commits into from
Closed

[SPARK-12145][SQL] Hive Authorization V2 interface requires the username information from SessionState #10144

wants to merge 3 commits into from

Conversation

winningsix
Copy link

We need to pass username information to SessionState in order to initial the Hive authorization V2.

@winningsix
Copy link
Author

Hi @vanzin
This PR includes two parts:

  1. Add user information to SessionState which is required to initialize the authorizer.
  2. Add parser rules to fallback "SET ROLE [rolename]" to Hive driver
    Could you please help me review this patch? Thank you!

@vanzin
Copy link
Contributor

vanzin commented Dec 9, 2015

This is not really my area, but I'm sure SQL guys will pick this up. ok to test

@SparkQA
Copy link

SparkQA commented Dec 9, 2015

Test build #47410 has finished for PR 10144 at commit d3498f9.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hvanhovell
Copy link
Contributor

@winningsix are you still working on this?

@winningsix
Copy link
Author

Hi @hvanhovell , I am still working on this. It would be great if you or some one can review this PR. Thank you!

@SparkQA
Copy link

SparkQA commented Jan 19, 2016

Test build #49656 has finished for PR 10144 at commit 7351f83.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 20, 2016

Test build #49744 has finished for PR 10144 at commit 8055065.

  • This patch fails Spark unit tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 20, 2016

Test build #49755 has finished for PR 10144 at commit 6436aa8.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 20, 2016

Test build #49754 has finished for PR 10144 at commit f031c12.

  • This patch fails Spark unit tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@hvanhovell hvanhovell mentioned this pull request Jan 25, 2016
Closed
asfgit pushed a commit that referenced this pull request Jan 27, 2016
@hvanhovell @rxin
[SPARK-12865][SPARK-12866][SQL] Migrate SparkSQLParser/ExtendedHiveQl…
ef96cd3 
…Parser commands to new Parser

This PR moves all the functionality provided by the SparkSQLParser/ExtendedHiveQlParser to the new Parser hierarchy (SparkQl/HiveQl). This also improves the current SET command parsing: the current implementation swallows ```set role ...``` and ```set autocommit ...``` commands, this PR respects these commands (and passes them on to Hive).

This PR and #10723 end the use of Parser-Combinator parsers for SQL parsing. As a result we can also remove the ```AbstractSQLParser``` in Catalyst.

The PR is marked WIP as long as it doesn't pass all tests.

cc rxin viirya winningsix (this touches #10144)

Author: Herman van Hovell <[email protected]>

Closes #10905 from hvanhovell/SPARK-12866.
@winningsix winningsix changed the title [SPARK-12145][SQL] Command 'Set Role [ADMIN|NONE|ALL]' doesn't work i… [SPARK-12145][SQL] Hive Authorization V2 interface requires the username information from SessionState Feb 4, 2016
@winningsix
Copy link
Author

Hi @hvanhovell @rxin , could you help me review this changes? I have updated the original pull request since changes in #10905.

@winningsix winningsix mentioned this pull request Feb 4, 2016
Closed
@SparkQA
Copy link

SparkQA commented Feb 4, 2016

Test build #50727 has finished for PR 10144 at commit 643ae61.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 4, 2016

Test build #50726 has finished for PR 10144 at commit 739f111.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jun 15, 2016

Thanks for the pull request. I'm going through a list of pull requests to cut them down since the sheer number is breaking some of the tooling we have. Due to lack of activity on this pull request, I'm going to push a commit to close it. Feel free to reopen it or create a new one. We can also continue the discussion on the JIRA ticket.

@asfgit asfgit closed this in 1a33f2e Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@winningsix @vanzin @SparkQA @hvanhovell @rxin