Skip to content

Commit

Permalink
[SPARK-45670][CORE][3.4] SparkSubmit does not support `--total-execut…
Browse files Browse the repository at this point in the history
…or-cores` when deploying on K8s

This is the cherry-pick of #43536 for branch-3.4

### What changes were proposed in this pull request?

Remove Kubernetes from the support list of `--total-executor-cores` in SparkSubmit

### Why are the changes needed?

`--total-executor-cores` does not take effect in Spark on K8s, [the
comments from original PR](#19717 (comment)) also proves that

### Does this PR introduce _any_ user-facing change?

The output of `spark-submit --help` changed

```patch
...
-  Spark standalone, Mesos and Kubernetes only:
+  Spark standalone and Mesos only:
    --total-executor-cores NUM  Total cores for all executors.
...
```
### How was this patch tested?

Pass GA and review.

### Was this patch authored or co-authored using generative AI tooling?

No

Closes #43549 from pan3793/SPARK-45670-3.4.

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
  • Loading branch information
pan3793 authored and HyukjinKwon committed Oct 27, 2023
1 parent 75aed56 commit 9c5d7c4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ private[spark] class SparkSubmit extends Logging {
confKey = EXECUTOR_CORES.key),
OptionAssigner(args.executorMemory, STANDALONE | MESOS | YARN | KUBERNETES, ALL_DEPLOY_MODES,
confKey = EXECUTOR_MEMORY.key),
OptionAssigner(args.totalExecutorCores, STANDALONE | MESOS | KUBERNETES, ALL_DEPLOY_MODES,
OptionAssigner(args.totalExecutorCores, STANDALONE | MESOS, ALL_DEPLOY_MODES,
confKey = CORES_MAX.key),
OptionAssigner(args.files, LOCAL | STANDALONE | MESOS | KUBERNETES, ALL_DEPLOY_MODES,
confKey = FILES.key),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ private[deploy] class SparkSubmitArguments(args: Seq[String], env: Map[String, S
| --kill SUBMISSION_ID If given, kills the driver specified.
| --status SUBMISSION_ID If given, requests the status of the driver specified.
|
| Spark standalone, Mesos and Kubernetes only:
| Spark standalone and Mesos only:
| --total-executor-cores NUM Total cores for all executors.
|
| Spark standalone, YARN and Kubernetes only:
Expand Down

0 comments on commit 9c5d7c4

Please sign in to comment.