Skip to content

Commit

Permalink
comments and format
Browse files Browse the repository at this point in the history
  • Loading branch information
hhbyyh committed Mar 16, 2016
1 parent f3fa1b9 commit 91f72a9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
4 changes: 2 additions & 2 deletions mllib/src/main/scala/org/apache/spark/ml/param/params.scala
Original file line number Diff line number Diff line change
Expand Up @@ -548,9 +548,9 @@ trait Params extends Identifiable with Serializable {
* Parameter value checks which do not depend on other parameters are handled by
* [[Param.validate()]]. This method does not handle input/output column parameters;
* those are checked during schema validation.
* @deprecated All the checks should be merged into transformSchema
* @deprecated Will be removed in 2.1.0. All the checks should be merged into transformSchema
*/
@deprecated("All the checks should be merged into transformSchema", "2.0.0")
@deprecated("Will be removed in 2.1.0. Checks should be merged into transformSchema.", "2.0.0")
def validateParams(): Unit = {
// Do nothing by default. Override to handle Param interactions.
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ private[regression] trait GeneralizedLinearRegressionBase extends PredictorParam
* to be used in the model.
* Supported options: "gaussian", "binomial", "poisson" and "gamma".
* Default is "gaussian".
*
* @group param
*
* @group param
*/
@Since("2.0.0")
final val family: Param[String] = new Param(this, "family",
Expand Down Expand Up @@ -80,7 +80,8 @@ private[regression] trait GeneralizedLinearRegressionBase extends PredictorParam
import GeneralizedLinearRegression._

@Since("2.0.0")
override def validateAndTransformSchema(schema: StructType,
override def validateAndTransformSchema(
schema: StructType,
fitting: Boolean,
featuresDataType: DataType): StructType = {
if ($(solver) == "irls") {
Expand Down

0 comments on commit 91f72a9

Please sign in to comment.