Skip to content

Commit

Permalink
new pylint ignore after rebase
Browse files Browse the repository at this point in the history
+ quiet mode for sphinx
  • Loading branch information
gsemet committed Oct 12, 2016
1 parent cd7184a commit 1252d08
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
6 changes: 4 additions & 2 deletions dev/lint-python
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,11 @@ cd "$SPARK_ROOT_DIR"
DEBUG=false
PIP_ARG="-q"
VIRTUALENV_ARG="-q"
SPHINX_ARGS="-q"
if [[ $1 == "--debug" || $1 == "-d" ]]; then
DEBUG=true
PIP_ARG=""
SPHINX_ARGS=""
VIRTUALENV_ARG=""
fi

Expand Down Expand Up @@ -135,13 +137,13 @@ if hash "$SPHINXBUILD" 2> /dev/null; then
echo "Building docs..."
make clean
# Treat warnings as errors so we stop correctly
SPHINXOPTS="-a -W" make html &> "$SPHINX_REPORT_PATH" || lint_status=1
SPHINXOPTS="-a -W $SPHINX_ARGS" make html &> "$SPHINX_REPORT_PATH" || lint_status=1
if [ "$lint_status" -ne 0 ]; then
echo "pydoc checks failed."
cat "$SPHINX_REPORT_PATH"
echo "re-running make html to print full warning list"
make clean
SPHINXOPTS="-a" make html
SPHINXOPTS="-a $SPHINX_ARGS" make html
rm "$SPHINX_REPORT_PATH"
exit "$lint_status"
else
Expand Down
3 changes: 3 additions & 0 deletions python/pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ disable=
cyclic-import,
dangerous-default-value,
deprecated-lambda,
deprecated-method,
duplicate-code,
eval-used,
exec-used,
Expand Down Expand Up @@ -154,10 +155,12 @@ disable=
unnecessary-pass,
unneeded-not,
unpacking-non-sequence,
unsubscriptable-object,
unused-argument,
unused-import,
unused-variable,
unused-wildcard-import,
used-before-assignment,
useless-else-on-loop,
wildcard-import,
wrong-import-order,
Expand Down

0 comments on commit 1252d08

Please sign in to comment.