Skip to content

Commit

Permalink
[SPARK-20974][BUILD] we should run REPL tests if SQL module has code …
Browse files Browse the repository at this point in the history
…changes

## What changes were proposed in this pull request?

REPL module depends on SQL module, so we should run REPL tests if SQL module has code changes.

## How was this patch tested?

N/A

Author: Wenchen Fan <[email protected]>

Closes #18191 from cloud-fan/test.

(cherry picked from commit 864d94f)
Signed-off-by: Wenchen Fan <[email protected]>
  • Loading branch information
cloud-fan committed Jun 3, 2017
1 parent 9952b53 commit 0f35988
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
2 changes: 1 addition & 1 deletion dev/run-tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def determine_modules_to_test(changed_modules):
>>> x = [x.name for x in determine_modules_to_test([modules.sql])]
>>> x # doctest: +NORMALIZE_WHITESPACE
['sql', 'hive', 'mllib', 'sql-kafka-0-10', 'examples', 'hive-thriftserver',
'pyspark-sql', 'sparkr', 'pyspark-mllib', 'pyspark-ml']
'pyspark-sql', 'repl', 'sparkr', 'pyspark-mllib', 'pyspark-ml']
"""
modules_to_test = set()
for module in changed_modules:
Expand Down
13 changes: 13 additions & 0 deletions dev/sparktestsupport/modules.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ def __hash__(self):
],
)


hive = Module(
name="hive",
dependencies=[sql],
Expand All @@ -142,6 +143,18 @@ def __hash__(self):
)


repl = Module(
name="repl",
dependencies=[hive],
source_file_regexes=[
"repl/",
],
sbt_test_goals=[
"repl/test",
],
)


hive_thriftserver = Module(
name="hive-thriftserver",
dependencies=[hive],
Expand Down

0 comments on commit 0f35988

Please sign in to comment.