Skip to content

Commit

Permalink
Review comment updates - remove extra newline, simplify assert in test
Browse files Browse the repository at this point in the history
  • Loading branch information
tgravescs committed Apr 7, 2014
1 parent 658a8ec commit 0803ec2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
1 change: 0 additions & 1 deletion core/src/main/scala/org/apache/spark/ui/SparkUI.scala
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ private[spark] class SparkUI(

private[spark] def appUIAddress = "http://" + publicHost + ":" + boundPort


}

private[spark] object SparkUI {
Expand Down
5 changes: 2 additions & 3 deletions core/src/test/scala/org/apache/spark/SparkUISuite.scala
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,11 @@ class SparkUISuite extends FunSuite with SharedSparkContext {

test("verify appUIHostPort doesn't contain scheme") {
val appUIUri = new URI(sc.ui.appUIHostPort)
assert(appUIUri.getScheme().startsWith("http") == false)
assert(!appUIUri.getScheme().startsWith("http"))
}

test("verify appUIAddress contains the scheme") {
val appUIUri = new URI(sc.ui.appUIAddress)
assert(appUIUri.getScheme().startsWith("http") == true)
assert(appUIUri.getScheme().startsWith("http"))
}

}

0 comments on commit 0803ec2

Please sign in to comment.