LUCENE-10523 illustration: hl.encoder=stripHTML #811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoerschke
commented
Apr 19, 2022
Comment on lines
+477
to
+487
| UHComponents components = getHighlightComponents(field, query, allTerms); | ||
| OffsetSource offsetSource = getOptimizedOffsetSource(components); | ||
|
|
||
| return new FieldHighlighter( | ||
| field, | ||
| getOffsetStrategy(offsetSource, components), | ||
| new SplittingBreakIterator(getBreakIterator(field), UnifiedHighlighter.MULTIVAL_SEP_CHAR), | ||
| getScorer(field), | ||
| maxPassages, | ||
| getMaxNoHighlightPassages(field), | ||
| getFormatter(field)) { |
There was a problem hiding this comment.
If there was a newFieldHighlighter method as proposed in apache/lucene#821 then the various get... calls here would not need duplicating when extending FieldHighlighter like this.
|
#2738 to explore moving from illustration to actual support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/LUCENE-10523