Update github PR link to use the new solr repo #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… those were actually correct with the old github repo anyway.
cpoerschke
reviewed
Apr 8, 2022
Co-authored-by: Christine Poerschke <[email protected]>
cpoerschke
approved these changes
Apr 10, 2022
risdenk
approved these changes
Apr 12, 2022
anshumg
approved these changes
Apr 12, 2022
janhoy
added a commit
that referenced
this pull request
Apr 26, 2022
* Remove the two existing PR references (#120 and #11) as none of those were actually correct with the old github repo anyway. Co-authored-by: Christine Poerschke <[email protected]> (cherry picked from commit d5ab86e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we convert CHANGES.txt to Changes.html, we support adding href links to text like "Pull Request #123". I counted and we only use it like 2 times, and both of those were incorrect, so I removed them.
NB: Perhaps we should allow a pattern like this as well, so you can add PRs to CHANGES without a JIRA:
I.e. in addition to the pattern
((?:(?:(?:github|gh)\s+)?pull\s+request\s*(?:\#?\s*)?|gh-)(\d+))also support^\*\s+\#\d{1..4}.