Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-17597: Fix CaffeineCache.put() ramBytes decrement #2917

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

SOLR-17597: Fix CaffeineCache.put() ramBytes decrement #2917

wants to merge 2 commits into from
+22 −18

Conversation

magibney
Copy link
Contributor

@magibney
Copy link
Contributor Author

This probably does not warrant a CHANGES.txt entry, since it doesn't impact any existing/default implementation or invocation of CaffeineCache.

NOTE: the second (V oldValue) arg to the private method CaffeineCache.recordRamBytes() is always null as now invoked, and could be removed. I will remove this unless anyone objects.

@magibney
Copy link
Contributor Author

This is a trivial change with no practical impact on the vast majority of users. I plan to merge this tomorrow, pending any feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cat:search tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@magibney