-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-17541: LBSolrClient implementations should agree on 'getClient()' semantics #2899
Open
jdyer1
wants to merge
34
commits into
apache:main
Choose a base branch
from
jdyer1:feature/SOLR-17541
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
5261cd3
Initial development
jdyer1 bc8c888
fix bugs
jdyer1 a249169
javadoc modifications
jdyer1 1f8a307
tidy / remove nocommit
jdyer1 90bf9e2
remove obsolete test
jdyer1 51676f5
Fix bug: (1) Only generate a client per base url, not base url+core.…
jdyer1 db76064
tidy
jdyer1 605bdc7
Only hold the internal builder
jdyer1 508af0d
remove override base url from jdk client
jdyer1 39177b4
fix test
jdyer1 35651b8
Merge branch 'main' into feature/SOLR-17541
jdyer1 19577dc
add missing @Override
jdyer1 ca59536
implement code review suggestions
jdyer1 67c8b8f
fix getClient/buildClient
dsmiley 7b90862
more
dsmiley 1539d97
PKI Authentication Plugin to add the listener factory to subsequently…
jdyer1 8f17279
@lucene.experimental annotations
jdyer1 effedb9
tidy
jdyer1 29a3445
remove system.out.println
jdyer1 50470cd
httpClientBuilder > httpSolrClientBuilder
jdyer1 f423bd2
API change to Http2SolrClient.Builder:
jdyer1 6176a99
Remove unnecessary null check
jdyer1 783f815
tidy
jdyer1 e8c998d
small change to doc comment
jdyer1 e035a0c
fix typo
jdyer1 99282aa
Better variable names
jdyer1 45b9e10
remove silly duplicate method
jdyer1 7df3c3b
variable rename
jdyer1 90bd2ec
Merge branch 'main' into feature/SOLR-17541
jdyer1 f984d12
TODO on HttpClientBuilderPlugin
jdyer1 28aec3b
CHANGES.txt
jdyer1 30dcdb3
tidy
jdyer1 730aad0
CHANGES.txt deprecation notice for Solr 9.9
jdyer1 071fb04
CHANGES.txt: mention rename LBHttp2SolrClient.Builder#withListenerFac…
jdyer1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest naming this param "builder" as it was, or "httpSolrClientBuilder". Note "client" is simply "client".