Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-16781: Fix missing change in RunExampleTool #2897

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

malliaridis
Copy link
Contributor

https://issues.apache.org/jira/browse/SOLR-16781

Description

A specific change was missing in the PR #2875 but present in the backport #2894, which leads to job execution failure.

Solution

Add the missing change.

Tests

none

Checklist

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG.... How did we miss this? How did our tests miss this?

@malliaridis
Copy link
Contributor Author

OMG.... How did we miss this? How did our tests miss this?

I think the tests reported the issue, but we just got used to failing jobs that it was just ignored. 😬

Or it was just a merge conflict that was resolved in a way that reset this specific line.

@malliaridis malliaridis merged commit 7547395 into apache:main Dec 6, 2024
3 of 4 checks passed
@gerlowskija
Copy link
Contributor

Gah! Thanks for catching this @malliaridis !

LGTM obviously

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants