Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17352: Backport removal of deprecated options for auth command (#2858) #2889

Conversation

malliaridis
Copy link
Contributor

https://issues.apache.org/jira/browse/SOLR-17352

Description

This PR backports the changes from #2858.

Solution

Additionally to the changes from #2858 this also updates the outdated --solr.home param in the output of bin/solr.cmd start --help.

Tests

Manually tested the presence of the bug and the fix by running bin/solr.cmd auth enable -s http://localhost:8983 --prompt true on a running instance (cloud mode).

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@malliaridis malliaridis requested a review from epugh November 27, 2024 16:07
Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malliaridis malliaridis merged commit 025c7a7 into apache:branch_9x Dec 1, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants