Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17576: Remove deprecated master/slave support in ReplicationHandler #2887

Merged
merged 8 commits into from
Dec 2, 2024

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Nov 27, 2024

https://issues.apache.org/jira/browse/SOLR-17576

Description

Remove deprecated terms.

Solution

Deletes

Tests

Existing tests

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@github-actions github-actions bot added documentation Improvements or additions to documentation tests labels Nov 27, 2024
@gus-asf
Copy link
Contributor

gus-asf commented Nov 27, 2024

I'm confused. There seems to be a lot more in this than just touching up terminology to match the Leader/Follower?

Copy link
Contributor

@gus-asf gus-asf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of the trivial stuff like spelling fixes isn't of concern, but I assume some of the larger deletions are removals of unused methods... I think that type of thing should be it's own change so that the reason for removal can be clearer to anyone who might have used it in 3rd party code or forks of our repo...

@epugh
Copy link
Contributor Author

epugh commented Nov 28, 2024

@gus-asf unfortuantly, I have to agree with you.... I'm going to redo this PR to seperate out the code cleanups from the deprecations. I just read @dsmiley link about "how to maintain forks" and it really pushed the atomicity of PR's. It kills me to be going through code and seeing obvious errors and problems and NOT fix them. The next time, I might try having two copies of Solr in seperate directories, and try to keep "annonying code issue fixes" on one, and the thrust of whatever I am doing on the other....

@epugh epugh requested a review from gus-asf November 29, 2024 12:18
@epugh
Copy link
Contributor Author

epugh commented Nov 29, 2024

I've removed the extra refactorings and created a new issue https://issues.apache.org/jira/browse/SOLR-17579 to track that (and remind me!)

@epugh epugh merged commit f9f4a07 into apache:main Dec 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants