-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-17576: Remove deprecated master/slave support in ReplicationHandler #2887
Conversation
I'm confused. There seems to be a lot more in this than just touching up terminology to match the Leader/Follower? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of the trivial stuff like spelling fixes isn't of concern, but I assume some of the larger deletions are removals of unused methods... I think that type of thing should be it's own change so that the reason for removal can be clearer to anyone who might have used it in 3rd party code or forks of our repo...
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
Outdated
Show resolved
Hide resolved
@gus-asf unfortuantly, I have to agree with you.... I'm going to redo this PR to seperate out the code cleanups from the deprecations. I just read @dsmiley link about "how to maintain forks" and it really pushed the atomicity of PR's. It kills me to be going through code and seeing obvious errors and problems and NOT fix them. The next time, I might try having two copies of Solr in seperate directories, and try to keep "annonying code issue fixes" on one, and the thrust of whatever I am doing on the other.... |
This reverts commit f7418bc.
I've removed the extra refactorings and created a new issue https://issues.apache.org/jira/browse/SOLR-17579 to track that (and remind me!) |
https://issues.apache.org/jira/browse/SOLR-17576
Description
Remove deprecated terms.
Solution
Deletes
Tests
Existing tests
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.