Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17567: Fix auth issue in stream tests #2877

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

malliaridis
Copy link
Contributor

https://issues.apache.org/jira/browse/SOLR-17567

Description

In #2479 an issue was introduced together with the stream tests that cause the bats tests to fail.

Solution

This PR applies a fix that is used in test_basic_auth.bats for enabling authentication. Bats tests are not starting with a clean state sometimes, and this is one situation that is affected by that.

Tests

A test for missing credentials was added. CLI output could be improved but is not task of this fix / PR.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@github-actions github-actions bot removed the cat:cli label Nov 19, 2024
@malliaridis
Copy link
Contributor Author

@epugh this one can be merged into #2872 as well. I think it's better to include them all together in one merge. :)

Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@malliaridis malliaridis merged commit 66a1680 into apache:main Nov 20, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants