Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Update com.google.errorprone:* to 2.31.0 (#2862) #2863

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

malliaridis
Copy link
Contributor

Description

Backports errorprone update to 9x. See #2862 for details.

Solution

Additional to the backported changes this PR removes unsupported static keywords in inner classes.

Tests

See #2862.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

* Update com.google.errorprone:* to 2.31.0
* Remove impossible null comparison
* Suppress wanted method references
* Fix ClassCanBeStatic warnings
* Remove null checks for primitive data types

(cherry picked from commit f6c5af9)
JDK 11 does not support static inner classes.
@malliaridis malliaridis merged commit 73e8260 into apache:branch_9x Nov 15, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant