Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Suppress printing out of password to console when using auth command #2857

Merged
merged 4 commits into from
Dec 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions solr/CHANGES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,8 @@ Improvements
* SOLR-16470: Replication "fetch file" API now has a v2 equivalent, available at `GET /api/cores/coreName/replication/files/fileName`
(Matthew Biscocho via Jason Gerlowski)

* SOLR-17554: Suppress printing out of password to console when using auth CLI command. (Christos Malliaridis via Eric Pugh)


Optimizations
---------------------
Expand Down
5 changes: 1 addition & 4 deletions solr/core/src/java/org/apache/solr/cli/AuthTool.java
Original file line number Diff line number Diff line change
Expand Up @@ -282,10 +282,7 @@ private void handleBasicAuth(CommandLine cli) throws Exception {
updateIncludeFileEnableAuth(includeFile, basicAuthConfFile);
final String successMessage =
String.format(
Locale.ROOT,
"Successfully enabled basic auth with username [%s] and password [%s].",
username,
password);
Locale.ROOT, "Successfully enabled basic auth with username [%s].", username);
echo(successMessage);
return;
case "disable":
Expand Down
Loading