Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17530: Prometheus regex cloud pattern fix for core names #2795

Merged
merged 4 commits into from
Nov 2, 2024

Conversation

mlbiscoc
Copy link
Contributor

@mlbiscoc mlbiscoc commented Oct 25, 2024

https://issues.apache.org/jira/browse/SOLR-17530

Description

The regex pattern for Solr cloud mode assumed all core names ended with a replica_n[0-9]+ which is incorrect. Some core names should be able to have any single character letter before the numbers.

Solution

Change regex pattern to with . instead of n to match any single character

Tests

testCloudCorePattern and testBadCloudCorePattern to test the regex cloud pattern.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@mlbiscoc
Copy link
Contributor Author

@dsmiley mind taking a look at this? Oversight on my part for the core regex pattern.

@dsmiley
Copy link
Contributor

dsmiley commented Oct 28, 2024

Thanks; an easy fix.
You linked this to SOLR-10654 but that issue was already released. A new issue must be created. We can get this into 9.7.1 (FYI @anshumg as RM)

@mlbiscoc mlbiscoc changed the title SOLR-10654: Prometheus regex cloud pattern fix for core names SOLR-17530: Prometheus regex cloud pattern fix for core names Oct 29, 2024
@dsmiley dsmiley merged commit 206904e into apache:main Nov 2, 2024
3 checks passed
dsmiley pushed a commit that referenced this pull request Nov 2, 2024
…eplicas (#2795)

The new Prometheus response writer wasn't detecting TLOG or PULL replicas properly.

---------

Co-authored-by: David Smiley <[email protected]>

(cherry picked from commit 206904e)
dsmiley pushed a commit that referenced this pull request Nov 2, 2024
…eplicas (#2795)

The new Prometheus response writer wasn't detecting TLOG or PULL replicas properly.

---------

Co-authored-by: David Smiley <[email protected]>

(cherry picked from commit 206904e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants