SOLR-17406: Introduce Version Catalogs #2706
Conversation
The implementation of the eclipse plugin throws "Value is null" error when trying to sync project without the palantir consistent versions plugin. Either fix the error or remove the configuration.
Move buildSrc into a composite included build (build-infra). Expose a plugin with buildinfra extension. See apache/lucene@4afae6a
github-actions
bot
added
documentation
|
I think it would be a good idea to first resolve the current solrbot PRs before aligning the versions. I am already looking into some of the PRs to see how they can be resolved. |
…sion-catalogs # Conflicts: # build-tools/scriptDepVersions.gradle # build.gradle # gradle/validation/check-environment.gradle # solr/core/build.gradle # solr/modules/hadoop-auth/build.gradle # solr/modules/hdfs/build.gradle # solr/server/build.gradle # solr/solrj-zookeeper/build.gradle # versions.lock # versions.props
malliaridis
force-pushed
the
SOLR-17406/rebase-version-catalogs
branch
from
788d305 to
6caff99
Compare
…sion-catalogs # Conflicts: # solr/modules/opentelemetry/build.gradle # versions.lock # versions.props
|
The current state should differ now only in hamcrest-core, which is being merged with hamcrest in the |
There was a problem hiding this comment.
What prompted you to update the NOTICE files of existing dependencies? -- very thorough of you but it would not have occurred to me. I found a couple misattributed LGPL references to correct but no other issue.
I ran the bats/integration tests and docker tests, and build the ref guide, just to exercise some parts of our build that might not otherwise in the PR validation. I think we should merge this very soon. A shout-out of the change arriving to our dev list would be helpful for general awareness and its impacts (e.g. dependency upgrades are now different and won't backport).
solr/licenses/netty-NOTICE.txt
Outdated
| * license/LICENSE.jboss-marshalling.txt (GNU LGPL 2.1) | ||
| * license/LICENSE.jboss-marshalling.txt (Apache License 2.0) |
There was a problem hiding this comment.
I checked this -- looks accurate. Then I got curious and searched out entire licenses folder for "LGPL". netty-transport-native-epoll-NOTICE.txt (and unix-common-NOTICE.txt) also makes a reference to LGPL but it's via the same jboss-marshalling line you are correcting here. So I think they can also be updated.
There was a problem hiding this comment.
The updates are originally coming from #2702. I looked up the repository and noticed a few changes there. It's probably best to make it a required step of the dependency update procedure. It should also be quite simple to find and copy-paste the files if they are on GitHub (or part of the jar, which is often not the case).
Apparently I missed to update the license and notice file of the rest of the netty dependencies. Since they come all from the same repository, it is probably best to merge the files into netty-LICENSE.txt and netty-NOTICE-txt by simply removing the other files. Should be part of SOLR-15929 though.
solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java
Outdated
Show resolved
Hide resolved
solr/core/src/test/org/apache/solr/handler/admin/IndexSizeEstimatorTest.java
Outdated
Show resolved
Hide resolved
solr/core/src/test/org/apache/solr/handler/admin/api/ReloadCoreAPITest.java
Outdated
Show resolved
Hide resolved
solr/core/src/test/org/apache/solr/handler/admin/api/UnloadCoreAPITest.java
Outdated
Show resolved
Hide resolved
…sion-catalogs # Conflicts: # solr/core/src/test/org/apache/solr/handler/admin/IndexSizeEstimatorTest.java # versions.lock # versions.props
|
Thanks @gus-asf for your review and input. Your questions are pointing out some of our upcoming TODOs. I'll leave some comments about the current state on each of your comments, hopefully clarifying and answering your questions. FYI the documentation will be updated periodically in the near future as we work to clean up and improve specific processes. |
|
I have updated the documentation to hopefully be clearer, but it is still not perfect yet. I have created https://issues.apache.org/jira/browse/SOLR-17563 to address outdated documentation. |
https://issues.apache.org/jira/browse/SOLR-17406
Description
With the version catalogs all versions and references to them are managed in a single file and updated from there.
Solution
This PR introduces version catalogs and removes the palantir consistent versions plugin, since it is no longer needed.
For syncing versions a new gradle file (dependencies.gradle) is introduced, where the version of a dependency (either transitive or non-transitive) is set via constraints. This part of the changes should be improved in the future if possible to reduce the maintenance overhead.
This PR is split from #2646.
This PR is following the practices from apache/lucene#13484.
Note that this PR is not tested for backwards compatibility (9x).
Tests
No tests should be affected by this.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.