remove deprecated SolrParams methods #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epugh
reviewed
Sep 9, 2024
| @@ -417,8 +417,7 @@ public void testBandsWrap() throws SyntaxError { | |||
| QParser qparser = | |||
| h.getCore() | |||
| .getQueryPlugin("minhash") | |||
| .createParser( | |||
| "1, 2, 3, 4, 5, 6, 7, 8, 9, 10", SolrParams.toSolrParams(par), null, null); | |||
| .createParser("1, 2, 3, 4, 5, 6, 7, 8, 9, 10", par.toSolrParams(), null, null); | |||
There was a problem hiding this comment.
"par"? Sort of a nitpick, but maybe a more descriptive variable name? "params'?
epugh
approved these changes
Sep 9, 2024
asfgit
pushed a commit
that referenced
this pull request
Sep 11, 2024
(cherry picked from commit 5bc7c16)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed whilst code reading. The methods appear to have been deprecated in Solr 7.4 -- https://issues.apache.org/jira/browse/SOLR-11914 -- and so the removal here can be both for
mainandbranch_9xbranches.