-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-17285: Move RemoteSolrException to SolrClient in v10 #2587
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It's remarkable how many files were touched by this; I wouldn't have guessed.
Just need a CHANGES.txt entry in "Other" under the Solr 10 section.
like "SOLR-17285: RemoteSolrException moved from BaseHttpSolrClient to SolrClient (your name here)"
I am looking at BaseHttpSolrClient again, and I see that RemoteExecutionException is also something that'll need to be moved. It's not used in many places. I think it's reasonable to include that in the scope of this JIRA issue and PR; WDYT? But I don't love the name "RemoteExecutionException" and I'm not even convinced it needs to exist; like couldn't RemoteSolrException take a payload? Publishing it to SolrClient would give it undeserved visibility IMO. Hmmm. On the other hand, based on how it's used, this is so internal that maybe it should simply move to HttpSolrClientBase (which is the successor to BaseHttpSolrClient). I welcome your thoughts. |
This PR has had no activity for 60 days and is now labeled as stale. Any new activity or converting it to draft will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. Thank you for your contribution! |
@samuelrivascoding how shall I credit you (name you) in CHANGES.txt? If I don't hear back, it'll be literally that. |
Will merge as soon as Monday. I also plan to handle RemoteSolrException in a follow-up. |
https://issues.apache.org/jira/browse/SOLR-17285
Description
Moved RemoteSolrException to SolrClient from BaseHttpSolrClient
Solution
Moved RemoteSolrException class to SolrClient. Manually changed import statements from BaseHttpSolrClient to SolrClient if is not needed anymore for RemoteSolrException. Changed BaseHttpSolrClient.RemoteSolrException to SolrClient.RemoteSolrException
Tests
OUTPUT-org.apache.solr.cloud.HttpPartitionOnCommitTest.txt
OUTPUT-org.apache.solr.cloud.ReplaceNodeTest.txt
OUTPUT-org.apache.solr.handler.TestSolrConfigHandlerConcurrent.txt
OUTPUT-org.apache.solr.pkg.TestPackages.txt
I ran ./gradlew dev. It worked fine
./gradlew check
did not work. It said there were failing tests on unrelated filesChecklist
Please review the following and check all that apply:
main
branch../gradlew check
.