Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-10654: Introduce output of Prometheus metrics directly from Solr #2405
SOLR-10654: Introduce output of Prometheus metrics directly from Solr #2405
Changes from 4 commits
3c3095a
b38b55b
8eb18f7
f531e49
d594f50
59cc9b4
bc6a60a
a57ffb4
58fb18d
680a0a3
e4c5053
a802716
a57e107
c40dda3
0aa1b55
88e6347
5d399ef
58280e5
b8475f8
acde988
060bb59
7359d7c
835c946
6cce972
bceb4fe
f1b410a
a9ee37f
1949b5b
1d7b65a
d6786ec
d6bd407
9f1abbe
5da678c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so special-purpose that I think it doesn't belong here. Can we get away with not registering it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could not figure out a way to do with without registering it. Is there some example somewhere where a response writer exists without registering the class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind. We even have schema xml format, another special purpose one. Maybe some day this could be improved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I filed https://issues.apache.org/jira/browse/SOLR-17354 for improving this matter.