SOLR-16975: Remove loading of solr.xml from zookeeper (main branch only) #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java
Outdated
Show resolved
Hide resolved
# Conflicts: # solr/CHANGES.txt
dsmiley
approved these changes
Nov 1, 2023
janhoy
commented
Nov 7, 2023
|
|
||
| // TODO: Only job of this block is to | ||
| // delay starting a solr core to satisfy | ||
| // ZkFailoverTest test case... |
There was a problem hiding this comment.
Rewrite ZkFailoverTest to enforce a failed restart of cluster in a different way than relying on this sysprop hack...
|
So I fixed the last tests and broguht back some ZK connection code to Final review welcome. @dsmiley ? |
risdenk
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16975
Solr will now fail and exit if it finds
/solr.xmlin zookeeper, with a message on how to remove it.Have also cleaned up docs and some scripts that used
/solr.xmlas example of how to upload stuff to zookeeper.The
MiniSolrCloudClusterrelied on uploading a provided solr.xml to ZK, now it instead copies the provided file to each Jetty.