SOLR-16963: Fix usage of clientHostnameVerification #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests pass locally. |
risdenk
approved these changes
Sep 12, 2023
tflobbe
approved these changes
Sep 12, 2023
HoustonPutman
added a commit
that referenced
this pull request
Sep 13, 2023
- It no longer overrides the checkPeerName option - It once again acts as a server setting to check the client hostname against the client certificate (cherry picked from commit 901e0de)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16963
A lot more context is provided in the JIRA, so look there, but basically this prop was changed in 8.4.1 to override the checkPeerName option, even though they are separate concerns.