-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-16966: Add a first-class cache for OrdinalMaps #1899
base: main
Are you sure you want to change the base?
SOLR-16966: Add a first-class cache for OrdinalMaps #1899
Conversation
EDIT: now has a test suite; should be basically ready to commit, pending any feedback. |
I considered adding the
I'm hoping to commit this soon -- any feedback welcome! |
Proposed
I plan to commit this early next week, pending feedback. |
The last three commits (through b812467) introduce a subtle but substantial change that abstracts all the "metadata wrapper" accounting so that application code (SolrIndexSearcher, other users of caches) know nothing about any potential metadata wrappers around cache value entries. The cleanest place to do this is from the regenerator; I've added This approach works equally well for implementing more nuanced cache metrics (histograms, dumping cache contents, etc.). The overall approach is described in the javadocs here. It should be quite trivial to implement regenerators that implement custom metrics. |
A wrapping instance will always know that it's wrapping, and be capable of directly returning the backing (wrapped) cache via SolrCache.toInternal().
This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the [email protected] mailing list. Thank you for your contribution! |
This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. |
…LR-16966-ordinal-map-caches
This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution! |
See: SOLR-16966