Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-16956: fix not being able to stop a solr by port number #1880

Merged
merged 2 commits into from
Sep 5, 2023
Merged

SOLR-16956: fix not being able to stop a solr by port number #1880

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48e5c8f
fix not being able to stop a solr by port number
epugh Sep 1, 2023
b34c4c3
Update solr/bin/solr
epugh Sep 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions solr/bin/solr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1301,6 +1301,7 @@ if [ $# -gt 0 ]; then
exit 1
fi
SOLR_PORT="$2"
PROVIDED_SOLR_PORT=SOLR_PORT
epugh marked this conversation as resolved.
Show resolved Hide resolved
PASS_TO_RUN_EXAMPLE+=("-p" "$SOLR_PORT")
shift 2
;;
Expand Down
13 changes: 13 additions & 0 deletions solr/packaging/test/test_start_solr.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,16 @@ teardown() {
run bash -c 'solr stop -all 2>&1'
refute_output --partial 'forcefully killing'
}

@test "stop command for single port" {

solr start
solr start -p 7574
solr assert --started http://localhost:8983/solr --timeout 5000
solr assert --started http://localhost:7574/solr --timeout 5000

run solr stop -p 7574
solr assert --not-started http://localhost:7574/solr --timeout 5000
solr assert --started http://localhost:8983/solr --timeout 5000

}