-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency com.google.errorprone:error_prone_annotations to v2.22.0 #1701
Conversation
58da93a
to
4c7726e
Compare
not sure why the previous one was closed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[NotJavadoc](https://errorprone.info/bugpattern/NotJavadoc)
[StringCaseLocaleUsage](https://errorprone.info/bugpattern/StringCaseLocaleUsage)
[UnnecessaryTestMethodPrefix](https://errorprone.info/bugpattern/UnnecessaryTestMethodPrefix)
need to evaluate these new rules and add to gradle/validation/error-prone.gradle either enabling or disabling them.
5180b7e
to
50ed3af
Compare
50ed3af
to
11d0d7f
Compare
Need to evaluate these rules too:
|
11d0d7f
to
177e543
Compare
177e543
to
e45a63b
Compare
e45a63b
to
893227b
Compare
893227b
to
dfac087
Compare
dfac087
to
4370380
Compare
I'm looking at this today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through all the added rules and disabled ones we don't need. I fixed a few failures that were minor.
Hmmm well apparently locally didn't end up recompiling all the tests so doing that now :D |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
….22.0 (#1701) * Update dependency com.google.errorprone:error_prone_annotations to v2.22.0 Co-authored-by: Kevin Risden <[email protected]>
This PR contains the following updates:
2.18.0
->2.22.0
Release Notes
google/error-prone
v2.22.0
: Error Prone 2.22.0We are considering raising the minimum supported JDK from JDK 11 to JDK 17 in a future release of Error Prone, see #3803. Note that using a newer JDK version to run javac during the build doesn't prevent building code that is deployed to earlier versions, for example it's supported to use the JDK 17 javac and pass
--release 11
to compile Java 11 code that is deployed to a JDK 11 runtime. If you have feedback, please comment on #3803.New checks:
ClosingStandardOutputStreams
: Prevents accidentally closingSystem.{out,err}
with try-with-resourcesTruthContainsExactlyElementsInUsage
:containsExactly
is preferred overcontainsExactlyElementsIn
when creating new iterablesUnnecessaryAsync
: detects unnecessary use of async primitives in local (and hence single-threaded) scopesReturnAtTheEndOfVoidFunction
: detects unnecessaryreturn
statements at the end ofvoid
functionsMultimapKeys
: Suggests usingkeySet()
instead of iterating overMultimap.keys()
, which does not collapse duplicatesBug fixes and improvements:
AddressSelection
(google/error-prone@44b6552)Map.get
, etc. returnnull
(#2910)@RegisterExtension
(#3892)@SuppressWarnings("all")
(#4065)UMemberSelect
from matching method parameters (#2456)// fall out
comments on expression switches (#2709)exemptPrefixes
/exemptNames
for UnusedVariable via flags (#2753)Full Changelog: google/error-prone@v2.21.1...v2.22.0
v2.21.1
: Error Prone 2.21.1Changes:
AddressSelection
to discourage APIs that convert a hostname to a single addressFull Changelog: google/error-prone@v2.21.0...v2.21.1
v2.21.0
: Error Prone 2.21.0New Checkers:
AttemptedNegativeZero
: Prevents accidental use of-0
, which is the same as0
. The floating-point negative zero is-0.0
.ICCProfileGetInstance
: Warns on uses ofICC_Profile.getInstance(String)
, due to JDK-8191622.MutableGuiceModule
: Fields in Guice modules should befinal
.NullableOptional
: Discourages@Nullable
-annotatedOptional
s.OverridingMethodInconsistentArgumentNamesChecker
: Arguments of overriding method are inconsistent with overridden method.Fixed issues: #3976, #3986, #4001, #4002, #4026, #4027
Full Changelog: google/error-prone@v2.20.0...v2.21.0
v2.20.0
: Error Prone 2.20.0Changes:
New Checkers:
InlineTrivialConstant
UnnecessaryStringBuilder
BanClassLoader
DereferenceWithNullBranch
DoNotUseRuleChain
LockOnNonEnclosingClassLiteral
MissingRefasterAnnotation
NamedLikeContextualKeyword
NonApiType
Fixes issues: #2232, #2243, #2997, #3301, #3843, #3903, #3918, #3923, #3931, #3945, #3946
Full Changelog: google/error-prone@v2.19.1...v2.20.0
v2.19.1
: Error Prone 2.19.1This release fixes a binary compatibility issue when running on JDK 11, see #3895
Full Changelog: google/error-prone@v2.19.0...v2.19.1
v2.19.0
: Error Prone 2.19.0New Checkers:
NotJavadoc
StringCaseLocaleUsage
UnnecessaryTestMethodPrefix
Fixes issues: #956, #3504, #3654, #3703, #3731, #3737, #3760, #3779, #3796, #3809, #3813
Full Changelog: google/error-prone@v2.18.0...v2.19.0
Configuration
📅 Schedule: Branch creation - "* * * * 0" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot