Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP SOLR-16441: Upgrade Jetty to 11.x #1509

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

risdenk
Copy link
Contributor

@risdenk risdenk commented Mar 30, 2023

https://issues.apache.org/jira/browse/SOLR-16441

This is just an example of what this might look like.

The changes are broken down like this approximately:

  • 5% build.gradle changes to use jakarta libraries
  • 30% javax -> jakata string replacement in imports
  • 10% solr/licenses updates for Jetty upgrade/jakarta change
  • 55% solr/licenses removals due to hadoop-auth and s3-repository "removal"

@risdenk
Copy link
Contributor Author

risdenk commented Mar 30, 2023

This is NOT ready to merge yet, but tagging some folks to at least look and see if this is something that we want to pursue. I think eventually we will need to go in this direction, but I don't think it needs to happen in Solr 9.x

@thomaswoeckinger
Copy link
Contributor

Will this be part of Solr 10?

@risdenk risdenk force-pushed the SOLR-16441-jetty-11 branch from adc8d07 to 5f8d37d Compare October 10, 2023 17:43
@risdenk
Copy link
Contributor Author

risdenk commented Oct 10, 2023

@thomaswoeckinger no idea. this is updated to main now though. Still has the hadoop-auth and s3-repository modules disabled.

@jorgerod
Copy link

jorgerod commented Nov 3, 2023

Hi @risdenk

Spring boot 3.0 and 3.1 use jetty 11x but Spring boot 3.2 will use jetty 12x.

Maybe it would be more interesting to upgrade directly to jetty 12x, what do you think? Or release two versions, one with 11x and one with 12x?

@uschindler
Copy link
Contributor

I would recommend to use Jetty 12. It allows to use both servlet APIs so we can stay with javax.servlet. You can run them in parallel, but actually a single context must use one version. SO means all of Solr needs to decide which version.

I migarted one project here and it was great. There were some bugs in Jetty 12.0.0, but since 12.0.1 all worked fine.

@epugh
Copy link
Contributor

epugh commented Nov 3, 2023

Let's rip that bandaid off and get to 12! Jakarta EE!

@risdenk
Copy link
Contributor Author

risdenk commented Nov 6, 2023

I filed https://issues.apache.org/jira/browse/SOLR-17069 to look at Jetty 12.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants