undo TestDistributedSearch change by uncommenting commented out code

apache · Feb 16, 2024 · cb3c1cb · cb3c1cb
1 parent 2501f7b
commit cb3c1cb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java b/solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java
@@ -2288,10 +2288,9 @@ public ScoreMode scoreMode() {
         }
 
         populateNextCursorMarkFromTopDocs(qr, cmd, topDocs);
-        //        if (cmd.getSort() != null && !(cmd.getQuery() instanceof RankQuery) &&
-        // needScores) {
-        //          TopFieldCollector.populateScores(topDocs.scoreDocs, this, query);
-        //        }
+        if (cmd.getSort() != null && !(cmd.getQuery() instanceof RankQuery) && needScores) {
+          TopFieldCollector.populateScores(topDocs.scoreDocs, this, query);
+        }
         // nDocsReturned = topDocs.scoreDocs.length;
         // TODO: Is this correct?
         // hitsRelation = topDocs.totalHits.relation;

diff --git a/solr/core/src/test/org/apache/solr/TestDistributedSearch.java b/solr/core/src/test/org/apache/solr/TestDistributedSearch.java
@@ -1786,7 +1786,7 @@ private void testMinExactCount() throws Exception {
         CommonParams.ROWS,
         "200",
         CommonParams.SORT,
-        "id asc");
+        "score desc, id asc");
     assertIsExactHitCount(
         "q", "{!cache=false}id:1", CommonParams.MIN_EXACT_COUNT, "1", CommonParams.ROWS, "1");
     assertApproximatedHitCount(