Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Zookeeper Operator default version to 0.2.6 #93

Merged
merged 5 commits into from
Apr 9, 2020

Conversation

HoustonPutman
Copy link
Contributor

Describe your changes
Making the version of the example zookeeper operator and the default zookeeper version the same.

@HoustonPutman
Copy link
Contributor Author

@timterle is there anywhere else we need to update?

@timterle
Copy link
Contributor

@HoustonPutman There is a dependency in go.mod and go.sum on v0.2.5-rc0, maybe that should be changed as well? Otherwise I think this is enough, although I haven't built and tested this to confirm.

I have tested changing from emccorp/zookeeper to pravega/zookeeper by overriding the image in the config and it works when I run a simple deployment in Amazon EKS. But when I try a simple example in "Docker for Mac" this change causes the second zookeeper pod never to come up successfully. It exits with an error "java.lang.RuntimeException: My id 2 not in the peer list"

@sepulworld
Copy link
Contributor

Definitely need this. We ran into a lot of issues HA testing out zk-operator with emccorp/zookeeper only to then find out it shouldn't be used according to reading through issue tracker on pravega/zookeeper-operator

@HoustonPutman
Copy link
Contributor Author

I'm going to do some testing with this tomorrow, and see if I can get this merged.

@HoustonPutman
Copy link
Contributor Author

HoustonPutman commented Apr 8, 2020

Looks like v0.2.6, which uses gomodules, was released recently. Might as well see if that one works too, keep this as up to date as possible.

@HoustonPutman
Copy link
Contributor Author

@timterle as a bonus with v0.2.6, you will be able to use the ExternalDNS with your zookeeper ensemble as well. https://github.com/pravega/zookeeper-operator/releases/tag/v0.2.6-rc0

@HoustonPutman HoustonPutman changed the title Upgrade Zookeeper Operator default version to 0.2.5 Upgrade Zookeeper Operator default version to 0.2.6 Apr 9, 2020
@HoustonPutman
Copy link
Contributor Author

@timterle I have tested this on docker-for-mac and it works well for me, including scaling up and down the zookeeper cluster through the solrcloud CRD

@HoustonPutman HoustonPutman merged commit 3442918 into master Apr 9, 2020
@HoustonPutman HoustonPutman deleted the zk-op-version branch April 9, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants