Allow users to configure Solr container's SecurityContext #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No support yet in helm chart. Still need to prepare, tidy, e2e-test, etc. But need to vet approach first.
HoustonPutman
approved these changes
Jan 9, 2025
| @@ -38,6 +39,11 @@ func newBoolPtr(value bool) *bool { | |||
| return &newBool | |||
| } | |||
|
|
|||
| func newIntPtr(value int64) *int64 { | |||
There was a problem hiding this comment.
You should be able to use pointer.Int64(...) for this. (The pointer library being "k8s.io/utils/pointer")
There was a problem hiding this comment.
I see the I probably added the methods above that do the same thing. So we can always go and remove them independently, but let's not add another one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternate approach to #489.
#702 attempts to solve the same underlying issue by giving the Solr container in our STS template a hardcoded SecurityContext. But that effort is, at the time of writing, stalled out: partly due to questions about whether the hardcoded SecurityContext would be too restrictive for some usecases, and partly due to an inability to test in the relevant environments.
This PR takes a different approach by leaving the securityContext unset by default, and instead giving interested users the ability to specify an arbitrary securityContext as a part of their SolrCloud (or as a 'solr' helm chart setting). A securityContext can be provided in the resource YAML at
.spec.customSolrKubeOptions.podOptions.containerSecurityContext(or using thepodOptions.containerSecurityContextvariable in the helm chart).e.g.