Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test backup directory is writable to avoid chown #548

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

smoldenhauer-ish
Copy link
Contributor

No description provided.

@HoustonPutman HoustonPutman linked an issue Apr 12, 2023 that may be closed by this pull request
@HoustonPutman HoustonPutman changed the title feat: test backup directory is writable to avoid chown (#537) feat: test backup directory is writable to avoid chown Apr 12, 2023
@HoustonPutman
Copy link
Contributor

HoustonPutman commented Apr 12, 2023

Thanks for making the PR!

The tests do cover this use case, but I'm very glad you did manual testing to ensure that it worked for your use case!
Mind adding a short description of your testing to the PR description for posterity?

Also please add a changelog entry. You can find an example here: https://github.com/apache/solr-operator/pull/539/files#diff-5e33a9126c77070c5c0eb99dda42378496c379464576c543c5f9a731da91284f
Basically a short description (e.g. Avoid backup directory chown when directories are already writable), and links to the Github Issue and Github PR.

@smoldenhauer-ish
Copy link
Contributor Author

We did some (manual) tests with the changed statement.
If the backup directory already contains several backups from ~7x400 collections the execution time of the init container cp-solr-xml dropped from >10minutes (executing the chown) down to 2-3 seconds (executing only the directory writable test)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow restart of Solr Pod init_container cp-solr-xml chown
2 participants