Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zookeeper image should not default to pull Always #512

Merged
merged 2 commits into from
Dec 23, 2022
+8 −1
Merged

Zookeeper image should not default to pull Always #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d60ccf6
Zookeeper image should not default to pull Always
HoustonPutman Dec 22, 2022
36dd642
Add changelog entry and upgrade notes
HoustonPutman Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controllers/zk_api/zkcluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const (
DefaultZkContainerVersion = "0.2.14"

// DefaultZkContainerPolicy is the default container pull policy used
DefaultZkContainerPolicy = "Always"
DefaultZkContainerPolicy = v1.PullIfNotPresent

// DefaultTerminationGracePeriod is the default time given before the
// container is stopped. This gives clients time to disconnect from a
Expand Down
2 changes: 2 additions & 0 deletions docs/upgrade-notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ _Note that the Helm chart version does not contain a `v` prefix, which the downl
The maximum number of pods allowed down at any given time is aligned with the [Managed Update settings](solr-cloud/solr-cloud-crd.md#update-strategy) provided in the spec.
If this is not provided, the default setting (`25%`) is used.

- Provided Zookeeper pods use the `IfNotPresent` pullPolicy by default. Users that specify this field manually will not see a change.

### v0.6.0
- The default Solr version for the `SolrCloud` and `SolrPrometheusExporter` resources has been upgraded from `8.9` to `8.11`.
This will not affect any existing resources, as default versions are hard-written to the resources immediately.
Expand Down
5 changes: 5 additions & 0 deletions helm/solr-operator/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@ annotations:
links:
- name: GitHub PR
url: https://github.com/apache/solr-operator/pull/508
- kind: changed
description: Zookeeper images now use the IfNotPresent pullPolicy by default
links:
- name: GitHub PR
url: https://github.com/apache/solr-operator/pull/512/files
artifacthub.io/images: |
- name: solr-operator
image: apache/solr-operator:v0.7.0-prerelease
Expand Down