Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Solr Operator metrics when using the helm chart. #360

Merged
merged 3 commits into from
Nov 2, 2021

Conversation

HoustonPutman
Copy link
Contributor

Resolves #307

This does not use the protected metrics-endpoint described in the kubebuilder docs. This is also just using the default operator metrics. We can add additional metrics in future PRs.

The metrics have been enabled since #321 was implemented, but not when using the helm chart. This fixes that.

@HoustonPutman HoustonPutman requested a review from janhoy October 29, 2021 19:48
Copy link
Contributor

@janhoy janhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not tested

@HoustonPutman
Copy link
Contributor Author

Tested manually and was able to query the operator metrics through kubectl port-forward.

@HoustonPutman HoustonPutman merged commit 8732003 into apache:main Nov 2, 2021
@HoustonPutman HoustonPutman deleted the helm-metrics branch November 2, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose operator metrics
2 participants