Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom Lifecycle for Solr & PrometheusExporter containers #324

Merged
merged 11 commits into from
Sep 23, 2021
Merged

Support custom Lifecycle for Solr & PrometheusExporter containers #324

merged 11 commits into from
Sep 23, 2021

Conversation

vladiceanu
Copy link
Contributor

@vladiceanu vladiceanu commented Sep 20, 2021

Resolves #322

Describe your changes
This PR adds support for custom Lifecycle input for Solr main container. A user should be able to set lifecycle.preStop and lifecycle.postStart hooks through SolrCloud CR for Solr main container.

This PR also includes Helm chart changes to support lifecycle inputs.

Tested locally on minikube.

Copy link
Contributor

@HoustonPutman HoustonPutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! But I would like to see a test added 🙂

Great contribution 🎉

controllers/util/solr_util.go Show resolved Hide resolved
Copy link
Contributor

@HoustonPutman HoustonPutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@HoustonPutman HoustonPutman changed the title Support Lifecycle input for Solr container Support custom Lifecycle for Solr & PrometheusExporter containers Sep 23, 2021
@HoustonPutman HoustonPutman merged commit 38d5ff3 into apache:main Sep 23, 2021
@vladiceanu vladiceanu deleted the add-lifecycle branch September 23, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solr pods graceful shutdown
2 participants