Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ephemeral option for zk storage. #284

Merged
merged 6 commits into from
Jul 20, 2021

Conversation

HoustonPutman
Copy link
Contributor

@HoustonPutman HoustonPutman commented Jul 14, 2021

Resolves: #259

Adds an option for the storage type of the provided ZK cluster. Ephemeral or Persistent.

If the user does not provide either option, then the Solr Operator will use whatever type is used by the Solr pods. (which defaults to ephemeral if none is provided).

Since pravega/zookeeper-operator#215 was merged, the Zookeeper Operator has had the ability to deploy Zookeeper with Ephemeral Storage. All we have to do is provide this as an option through the SolrCloud CRD, and solr helm chart.

This is a breaking change that requires a note in the Upgrade Notes, because the ZK storage now defaults to ephemeral if a user is using ephemeral storage for Solr. In previous versions of the Solr Operator, only persistent ZK storage is supported, so this is clearly a change to default deployments.

New options are found in:

SolrCloud CRD

spec:
  zookeeperRef:
    provided:
      persistence: {} # Always an option
      ephemeral: {} # New option introduced in this PR

Solr Helm Chart

zk:
  provided:
    storageType: "" # Explicitly set the type, since empty objects are ignored in helm. Not necessary to use
    persistence: {} # Always an option
    ephemeral: {} # New option introduced in this PR

@HoustonPutman HoustonPutman merged commit 7701225 into apache:main Jul 20, 2021
@HoustonPutman HoustonPutman deleted the zk-ephemeral-storage branch July 20, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ephemeral storage should extend to ZK instance
1 participant