Basic TLS Support #209
Merged
Basic TLS Support #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Potter <[email protected]>
Signed-off-by: Timothy Potter <[email protected]>
Signed-off-by: Timothy Potter <[email protected]>
Signed-off-by: Timothy Potter <[email protected]>
Signed-off-by: Timothy Potter <[email protected]>
Signed-off-by: Timothy Potter <[email protected]>
… when using self-signed certs
HoustonPutman
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150
Taking a simplified approach than what was attempted in #151 by removing
autoCreatemode and instead relying on users to create the TLS secret however they see fit. The approach in this PR avoids introducing a dependency on cert-manager, although we still recommend users use cert-manager if they don't already have a TLS certificate solution in place.