Use solr.xml from provided ConfigMap #158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Timothy Potter [email protected]
This fixes #86
Introduce a new var
ProvidedConfigMap
in theCustomSolrKubeOptions.ConfigMapOptions
to allow users to supply the name of a ConfigMap containing a customsolr.xml
. If supplied, we track the MD5 checksum of thesolr.xml
data in an annotation on the pod spec (solr.apache.org/solrXmlMd5
) for the StatefulSet to trigger a rolling restart when thesolr.xml
in theConfigMap
changes. If supplied on theSolrCloud
CRD, the controller requires the providedConfigMap
to contain asolr.xml
that must have a placeholder for the operator to set thehostPort
variable, e.g.Includes a unit test that verifies proper reconciliation using a provided ConfigMap and that an update to the
solr.xml
triggers a rolling restart of the StatefulSet (via the annotation changing).I also tested this manually in Kubernetes by creating my own ConfigMap:
And then referencing it in the SolrCloud definition: