Adding hosted helm chart with deployment script. #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Houston Putman <[email protected]>
|
This is awesome! We will definitely use the helm repo here!
|
pawalt
suggested changes
May 8, 2020
Makefile
Outdated
| @@ -32,6 +32,9 @@ clean: | |||
| mod-tidy: | |||
| export GO111MODULE=on; go mod tidy | |||
|
|
|||
| release: | |||
There was a problem hiding this comment.
Maybe helm-release or helm-publish or something like that? Just don't want this to be confused with actually cutting a new release.
There was a problem hiding this comment.
Added some docs around creating releases to make sure I (and others) don't miss anything in the future. I want this task to auto-create the release at some point...
Actually maybe I'll script out the necessary git commands.
There was a problem hiding this comment.
Gotcha that totally makes sense. Releases would probably be pretty easy to script out with the github cli, but that's a different PR.
Signed-off-by: Houston Putman <[email protected]>
Signed-off-by: Houston Putman <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to host a helm repo in the github pages of this github repository (bloomberg.github.io/solr-operator/charts).
I still need to fix the documentation in the getting started, and add documentation around doing releases. But I think the logic should be there.