Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoherent naming for additional domainNames variable (code vs. documentation) #412

Closed
mmoscher opened this issue Mar 7, 2022 · 2 comments · Fixed by #416
Closed

Incoherent naming for additional domainNames variable (code vs. documentation) #412

mmoscher opened this issue Mar 7, 2022 · 2 comments · Fixed by #416
Assignees

Comments

@mmoscher
Copy link
Contributor

mmoscher commented Mar 7, 2022

Helm-Chart and CRD documentations mentions a additionalDomainNames variable to provide further domainNames.
However, the CRD itself parses additionalDomains only.

@HoustonPutman
Copy link
Contributor

The approach we have to take (for back-compat as well as rules around minor & patch releases) is:

@mmoscher
Copy link
Contributor Author

mmoscher commented Mar 16, 2022

@HoustonPutman thanks for taking over. I was the last week (unfortunately 😄 ) on vacation and therefore could not take care of it.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants