Skip to content

Commit

Permalink
Correct query-param name used by prom-exporter probe (#729)
Browse files Browse the repository at this point in the history
A previous change introduced the use of the `names` parameter to avoid
exporting metrics, but the correct param-name is `name` (no '-s' suffix).
  • Loading branch information
smoldenhauer-ish authored Dec 9, 2024
1 parent 630efa0 commit ccf54fd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion controllers/util/prometheus_exporter_util.go
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ func GenerateSolrPrometheusExporterDeployment(solrPrometheusExporter *solr.SolrP
HTTPGet: &corev1.HTTPGetAction{
Scheme: corev1.URISchemeHTTP,
// TODO: When 9.0 is the minimum supported version, this can be "/-/healthy"
Path: "/metrics?names[]=",
Path: "/metrics?name[]=",
Port: intstr.FromInt(SolrMetricsPort),
},
}
Expand Down

0 comments on commit ccf54fd

Please sign in to comment.