Add shareProcessNamespace flag to podOptions

Boolean flag defaults unset, and is available in the CRD at
`.spec.customSolrKubeOptions.podOptions.shareProcessNamespace`

api/v1beta1/common_types.go

@@ -137,6 +137,10 @@ type PodOptions struct {
 	// +optional
 	ServiceAccountName string `json:"serviceAccountName,omitempty"`
 
+	// Should process namespace sharing be enabled on created pods
+	// +optional
+	ShareProcessNamespace *bool `json:"shareProcessNamespace,omitempty"`
+
 	// Optional PodSpreadTopologyConstraints to use when scheduling pods.
 	// More information here: https://kubernetes.io/docs/concepts/workloads/pods/pod-topology-spread-constraints/
 	//

config/crd/bases/solr.apache.org_solrclouds.yaml

@@ -5082,6 +5082,10 @@ spec:
                       serviceAccountName:
                         description: Optional Service Account to run the pod under.
                         type: string
+                      shareProcessNamespace:
+                        description: Should process namespace sharing be enabled on
+                          created pods
+                        type: boolean
                       sidecarContainers:
                         description: Sidecar containers to run in the pod. These are
                           in addition to the Solr Container

config/crd/bases/solr.apache.org_solrprometheusexporters.yaml

@@ -3173,6 +3173,10 @@ spec:
                       serviceAccountName:
                         description: Optional Service Account to run the pod under.
                         type: string
+                      shareProcessNamespace:
+                        description: Should process namespace sharing be enabled on
+                          created pods
+                        type: boolean
                       sidecarContainers:
                         description: Sidecar containers to run in the pod. These are
                           in addition to the Solr Container

controllers/solrcloud_controller_test.go

@@ -25,6 +25,7 @@ import (
 	"github.com/apache/solr-operator/controllers/util"
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
+	. "github.com/onsi/gomega/gstruct"
 	appsv1 "k8s.io/api/apps/v1"
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -146,6 +147,7 @@ var _ = FDescribe("SolrCloud controller - General", func() {
 			Expect(statefulSet.Spec.Template.Spec.Volumes).To(HaveLen(len(extraVolumes)+3), "Pod has wrong number of volumes")
 			Expect(statefulSet.Spec.Template.Spec.Volumes[3].Name).To(Equal(extraVolumes[0].Name), "Additional Volume from podOptions not loaded into pod properly.")
 			Expect(statefulSet.Spec.Template.Spec.Volumes[3].VolumeSource).To(Equal(extraVolumes[0].Source), "Additional Volume from podOptions not loaded into pod properly.")
+			Expect(statefulSet.Spec.Template.Spec.ShareProcessNamespace).Should(PointTo(BeFalse()))
 			Expect(statefulSet.Spec.Template.Spec.ReadinessGates).To(ContainElement(corev1.PodReadinessGate{ConditionType: util.SolrIsNotStoppedReadinessCondition}), "All pods should contain the isNotStopped readinessGate.")
 
 			By("testing the Solr Common Service")
@@ -169,6 +171,7 @@ var _ = FDescribe("SolrCloud controller - General", func() {
 
 	FContext("Solr Cloud with Custom Kube Options", func() {
 		three := intstr.FromInt(3)
+		testShareProcessNamespace := true
 		BeforeEach(func() {
 			replicas := int32(4)
 			solrCloud.Spec = solrv1beta1.SolrCloudSpec{
@@ -213,6 +216,7 @@ var _ = FDescribe("SolrCloud controller - General", func() {
 						TopologySpreadConstraints:     testTopologySpreadConstraints,
 						DefaultInitContainerResources: testResources2,
 						InitContainers:                extraContainers1,
+						ShareProcessNamespace:         &testShareProcessNamespace,
 					},
 					StatefulSetOptions: &solrv1beta1.StatefulSetOptions{
 						Annotations:         testSSAnnotations,
@@ -284,6 +288,7 @@ var _ = FDescribe("SolrCloud controller - General", func() {
 			Expect(statefulSet.Spec.Template.Spec.ServiceAccountName).To(Equal(testServiceAccountName), "Incorrect serviceAccountName")
 			Expect(statefulSet.Spec.Template.Spec.TopologySpreadConstraints).To(HaveLen(len(testTopologySpreadConstraints)), "Wrong number of topologySpreadConstraints")
 			Expect(statefulSet.Spec.Template.Spec.TopologySpreadConstraints[0]).To(Equal(testTopologySpreadConstraints[0]), "Wrong first topologySpreadConstraint")
+			Expect(statefulSet.Spec.Template.Spec.ShareProcessNamespace).To(Equal(&testShareProcessNamespace), "Wrong shareProcessNamespace value")
 			expectedSecondTopologyConstraint := testTopologySpreadConstraints[1].DeepCopy()
 			expectedSecondTopologyConstraint.LabelSelector = statefulSet.Spec.Selector
 			Expect(statefulSet.Spec.Template.Spec.TopologySpreadConstraints[1]).To(Equal(*expectedSecondTopologyConstraint), "Wrong second topologySpreadConstraint")

controllers/util/solr_util.go

@@ -82,6 +82,7 @@ var (
 // zkConnectionString: the connectionString of the ZK instance to connect to
 func GenerateStatefulSet(solrCloud *solr.SolrCloud, solrCloudStatus *solr.SolrCloudStatus, hostNameIPs map[string]string, reconcileConfigInfo map[string]string, tls *TLSCerts, security *SecurityConfig) *appsv1.StatefulSet {
 	terminationGracePeriod := int64(60)
+	shareProcessNamespace := false
 	solrPodPort := solrCloud.Spec.SolrAddressability.PodPort
 	defaultFSGroup := int64(DefaultSolrGroup)
 
@@ -122,6 +123,9 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud, solrCloudStatus *solr.SolrCl
 		if customPodOptions.TerminationGracePeriodSeconds != nil {
 			terminationGracePeriod = *customPodOptions.TerminationGracePeriodSeconds
 		}
+		if customPodOptions.ShareProcessNamespace != nil {
+			shareProcessNamespace = *customPodOptions.ShareProcessNamespace
+		}
 	}
 
 	// The isNotStopped readiness gate will always be used for managedUpdates
@@ -543,6 +547,7 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud, solrCloudStatus *solr.SolrCl
 
 				Spec: corev1.PodSpec{
 					TerminationGracePeriodSeconds: &terminationGracePeriod,
+					ShareProcessNamespace:         &shareProcessNamespace,
 					SecurityContext: &corev1.PodSecurityContext{
 						FSGroup: &defaultFSGroup,
 					},

helm/solr-operator/Chart.yaml

@@ -61,6 +61,13 @@ annotations:
           url: https://github.com/apache/solr-operator/issues/684
         - name: Github PR
           url: https://github.com/apache/solr-operator/pull/685
+    - kind: added
+      description: SolrClouds now support namespace sharing among pod containers in a pod.
+      links:
+        - name: Github Issue
+          url: https://github.com/apache/solr-operator/issues/716
+        - name: Github PR
+          url: https://github.com/apache/solr-operator/pull/735
     - kind: changed
       description: SolrClouds now support auto-readOnlyRootFilesystem setting.
       links:

helm/solr-operator/crds/crds.yaml

@@ -5343,6 +5343,10 @@ spec:
                       serviceAccountName:
                         description: Optional Service Account to run the pod under.
                         type: string
+                      shareProcessNamespace:
+                        description: Should process namespace sharing be enabled on
+                          created pods
+                        type: boolean
                       sidecarContainers:
                         description: Sidecar containers to run in the pod. These are
                           in addition to the Solr Container
@@ -19456,6 +19460,10 @@ spec:
                       serviceAccountName:
                         description: Optional Service Account to run the pod under.
                         type: string
+                      shareProcessNamespace:
+                        description: Should process namespace sharing be enabled on
+                          created pods
+                        type: boolean
                       sidecarContainers:
                         description: Sidecar containers to run in the pod. These are
                           in addition to the Solr Container