SLING-11229 - Support Configurable Limit for JCR Resource Provider Query Methods #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… JCR Resource Provider query provider and support parsing the start and limit values out of query comments
joerghoh
approved these changes
Mar 30, 2022
src/main/java/org/apache/sling/jcr/resource/internal/helper/JcrResourceUtil.java
Outdated
Show resolved
Hide resolved
| @AttributeDefinition(name = "Enable Query Limit", description = "If set to true, the JcrResourceProvider will set a default limit for all other queries using the findResources / queryResources methods") | ||
| boolean enable_query_limit() default false; | ||
|
|
||
| @AttributeDefinition(name = "Query Limit", description = "The default query limit for queries using the findResources / queryResources methods") |
There was a problem hiding this comment.
Suggested change
| @AttributeDefinition(name = "Query Limit", description = "The default query limit for queries using the findResources / queryResources methods") | |
| @AttributeDefinition(name = "Query Limit", description = "The default query limit for queries using the findResources / queryResources methods. It will only take effect if the query limit feature is enabled.") |
src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrResourceProvider.java
Outdated
Show resolved
Hide resolved
…r/JcrResourceProvider.java Co-authored-by: Jörg Hoh <[email protected]>
…rResourceUtil.java Co-authored-by: Jörg Hoh <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #21
This just covers enabling the JCR Resource Provider to configure a limit for the JCR Resource Provider's BasicQueryLanguageProvider.