Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2546 #2551

Merged
merged 7 commits into from
Apr 29, 2019
Merged

Fix #2546 #2551

merged 7 commits into from
Apr 29, 2019

Conversation

ascrutae
Copy link
Member

Please answer these questions before submitting pull request

@ascrutae ascrutae added bug Something isn't working and you are sure it's a bug! agent Language agent related. labels Apr 28, 2019
@ascrutae ascrutae added this to the 6.1.0 milestone Apr 28, 2019
@ascrutae ascrutae requested a review from wu-sheng April 28, 2019 13:05
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline.

@ascrutae ascrutae force-pushed the fix/spring-plugin-issue branch from 99c9e44 to a4ad679 Compare April 28, 2019 15:54
@coveralls
Copy link

coveralls commented Apr 28, 2019

Coverage Status

Coverage remained the same at 16.011% when pulling 6f7e27b on ascrutae:fix/spring-plugin-issue into f02300a on apache:master.

@wu-sheng wu-sheng requested a review from IanCao April 29, 2019 00:11
Copy link
Contributor

@IanCao IanCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit 31cb96d into apache:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related. bug Something isn't working and you are sure it's a bug!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants