Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix skywalking s3 upload error #82

Merged
merged 1 commit into from
May 19, 2022
Merged

Fix skywalking s3 upload error #82

merged 1 commit into from
May 19, 2022

Conversation

wuwen5
Copy link
Contributor

@wuwen5 wuwen5 commented May 19, 2022 •
edited
Loading

@wuwen5 wuwen5 mentioned this pull request May 19, 2022
Closed
3 tasks
@kezhenxu94 kezhenxu94 added the bug Something isn't working label May 19, 2022
@wu-sheng wu-sheng requested review from tom-pytel and kezhenxu94 May 19, 2022 02:15
@wu-sheng wu-sheng changed the title fix #8824 fix skywalking s3 upload error May 19, 2022
@kezhenxu94 kezhenxu94 changed the title fix skywalking s3 upload error Fix skywalking s3 upload error May 19, 2022
kezhenxu94
kezhenxu94 approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works, thanks @wuwen5 👍

@kezhenxu94 kezhenxu94 merged commit 92fe2ad into apache:master May 19, 2022
@kezhenxu94 kezhenxu94 added this to the 0.5.0 milestone May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@tom-pytel tom-pytel Awaiting requested review from tom-pytel

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wuwen5 @kezhenxu94