Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix awaits and SW_AWSLAMBDA_FLUSH default #72

Merged
merged 2 commits into from
Feb 24, 2022
Merged

fix awaits and SW_AWSLAMBDA_FLUSH default #72

merged 2 commits into from
Feb 24, 2022

Conversation

tom-pytel
Copy link
Contributor

@tom-pytel tom-pytel commented Feb 23, 2022 •
edited
Loading

  • Added awaits where they were missing before.
  • Set correct default for SW_AWSLAMBDA_FLUSH.
  • Let event loop tick once before flush in case child spans have finalizer waiting in the loop, if they don't proc then the segment is not archived and flushed.

@tom-pytel tom-pytel added the bug Something isn't working label Feb 23, 2022
@tom-pytel tom-pytel added this to the 0.4.0 milestone Feb 23, 2022
@tom-pytel tom-pytel requested a review from kezhenxu94 February 23, 2022 14:44
kezhenxu94
kezhenxu94 previously approved these changes Feb 23, 2022
View reviewed changes
@wu-sheng wu-sheng requested a review from kezhenxu94 February 23, 2022 23:53
@kezhenxu94 kezhenxu94 merged commit c3a74c9 into apache:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-pytel @kezhenxu94