-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added http protocol to plugins #28
Conversation
Ok, I really do not understand, I changed the fields affected by the PR in the expected.data.yaml files and it still fails. Comparing the "actualData" from the failure against the expected data it all matches up except for some "isError: false" which are not present in expected.data.yaml, but that yaml without the "isError" is coming from the previous successful master which I assume is ok. So for future pushes so that I can get the test right can you please show me what I am missing in order to get the test to succeed? |
That is what we're doing to find out what's wrong.
May be more carefully when comparing? 🤣 I compare those and see the orders of the tags are different, so please always keep in mind the verifier is not that flexible to ignore the orders |
🤦 |
Ok wait a minute, but I didn't change the order of tags, those were the .yaml files from a previous SUCCESSFUL master and all I did was change the url VALUE, didn't add or remove any other fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
No description provided.