Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added http protocol to plugins #28

Merged
merged 10 commits into from
Jan 27, 2021
Merged

Added http protocol to plugins #28

merged 10 commits into from
Jan 27, 2021

Conversation

tom-pytel
Copy link
Contributor

No description provided.

@tom-pytel
Copy link
Contributor Author

Ok, I really do not understand, I changed the fields affected by the PR in the expected.data.yaml files and it still fails. Comparing the "actualData" from the failure against the expected data it all matches up except for some "isError: false" which are not present in expected.data.yaml, but that yaml without the "isError" is coming from the previous successful master which I assume is ok. So for future pushes so that I can get the test right can you please show me what I am missing in order to get the test to succeed?

@kezhenxu94 kezhenxu94 changed the title added http.method to plugins Added http protocol to plugins Jan 27, 2021
@kezhenxu94
Copy link
Member

Comparing the "actualData" from the failure against the expected data it all matches up except for some "isError: false" which are not present in expected.data.yaml, but that yaml without the "isError" is coming from the previous successful master which I assume is ok.

That is what we're doing to find out what's wrong.

So for future pushes so that I can get the test right can you please show me what I am missing in order to get the test to succeed?

May be more carefully when comparing? 🤣 I compare those and see the orders of the tags are different, so please always keep in mind the verifier is not that flexible to ignore the orders

@tom-pytel
Copy link
Contributor Author

Comparing the "actualData" from the failure against the expected data it all matches up except for some "isError: false" which are not present in expected.data.yaml, but that yaml without the "isError" is coming from the previous successful master which I assume is ok.

That is what we're doing to find out what's wrong.

So for future pushes so that I can get the test right can you please show me what I am missing in order to get the test to succeed?

May be more carefully when comparing? I compare those and see the orders of the tags are different, so please always keep in mind the verifier is not that flexible to ignore the orders

🤦

@kezhenxu94 kezhenxu94 added the enhancement New feature or request label Jan 27, 2021
@kezhenxu94 kezhenxu94 added this to the 0.2.0 milestone Jan 27, 2021
@tom-pytel
Copy link
Contributor Author

May be more carefully when comparing? I compare those and see the orders of the tags are different, so please always keep in mind the verifier is not that flexible to ignore the orders

Ok wait a minute, but I didn't change the order of tags, those were the .yaml files from a previous SUCCESSFUL master and all I did was change the url VALUE, didn't add or remove any other fields.

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kezhenxu94 kezhenxu94 merged commit 01794e3 into apache:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants