Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AxiosPlugin for v1.0+ #102

Merged
merged 12 commits into from
Nov 15, 2022
Merged

Update AxiosPlugin for v1.0+ #102

merged 12 commits into from
Nov 15, 2022

Conversation

tom-pytel
Copy link
Contributor

Old plugin doesn't work with v1.0+, dropping support for < v1.0. Tests will probably break so will see how to fix.

@tom-pytel tom-pytel added this to the 0.6.0 milestone Nov 14, 2022
@tom-pytel tom-pytel requested a review from kezhenxu94 November 14, 2022 15:14
@tom-pytel
Copy link
Contributor Author

tom-pytel commented Nov 14, 2022

@kezhenxu94 @wu-sheng
Newest Axios seems to be incompatible with Node 10. Suggest dropping Node 10 support since lowest Node currently getting security updates is 14 and latest version is 19.

@wu-sheng
Copy link
Member

v1.0 is released one month ago, https://github.com/axios/axios/releases/tag/v1.0.0

Are we too aggressive to drop the old version release? @kezhenxu94 Do we have a way to build plugin for various versions? As a result, we could keep the plugin for 0.x and one more for 1.x

@tom-pytel
Copy link
Contributor Author

Are we too aggressive to drop the old version release? @kezhenxu94 Do we have a way to build plugin for various versions? As a result, we could keep the plugin for 0.x and one more for 1.x

Not a big problem to leave it compatible with old Axios for old Node 10, this should work for all versions, lets see what tests say. I left test version as old Axios because otherwise Node 10 test would fall over and die.

@tom-pytel tom-pytel merged commit 22f5352 into apache:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants