-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AxiosPlugin for v1.0+ #102
Conversation
@kezhenxu94 @wu-sheng |
v1.0 is released one month ago, https://github.com/axios/axios/releases/tag/v1.0.0 Are we too aggressive to drop the old version release? @kezhenxu94 Do we have a way to build plugin for various versions? As a result, we could keep the plugin for 0.x and one more for 1.x |
Not a big problem to leave it compatible with old Axios for old Node 10, this should work for all versions, lets see what tests say. I left test version as old Axios because otherwise Node 10 test would fall over and die. |
Old plugin doesn't work with v1.0+, dropping support for < v1.0. Tests will probably break so will see how to fix.