[SHIRO-770] Remove base64 implementation, keep UTF-8 codec by default. #224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For v2.0.0, we probably do not want to maintain our own Base64 implementation.
Still, the shiro implementation defaulted to UTF-8 for decoding strings, which seems to be a sane default.
However, the
CryptoException
became unreachable from the Base64 class. As this is not cryptography anyway, I decided to replace it with theIllegalArgumentException
thrown byjava.util.Base64
's methods.