[#1381] enh: Build on JDK 22 #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarwell
previously requested changes
Jun 12, 2024
tools/hasher/pom.xml
Outdated
Comment on lines
40
to
49
| <artifactId>shiro-core</artifactId> | ||
| <exclusions> | ||
| <!-- BeanUtils is for ini config - this simple command line program | ||
| does not init a shiro environment, so we don't need it: --> | ||
| <exclusion> | ||
| <groupId>commons-beanutils</groupId> | ||
| <artifactId>commons-beanutils</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> |
There was a problem hiding this comment.
Do you really want to introduce one extra dependency for just one invocation?
There was a problem hiding this comment.
I was able to make reflection a one-liner, so that works just as well as PropertyUtils
Thanks!
| private static boolean isTerminal(java.io.Console console) throws IOException { | ||
| try { | ||
| // isTerminal is only available in Java 22 or later | ||
| return console != null && (Boolean) PropertyUtils.getProperty(console, "terminal"); |
There was a problem hiding this comment.
Can we use standard reflection here? I dont want to introduce a dependency just for one line.
Also, newer JDKs will bring better Reflection tools iirc.
Comment on lines
498
to
500
| if (!isTerminal(console)) { | ||
| throw new IllegalStateException("Cannot confirm password when console is not available."); | ||
| } |
There was a problem hiding this comment.
Maybe on non-Terminals, just use one input instead of to (i.e. do not throw an exception and just go for it).
Otherwise this might break script invocations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
isTerminal()check to Hasher tool, as JDK 22 changed console functionalityRun JDK 22 in CI
fixes #1381
Following this checklist to help us incorporate your contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
[#XXX] - Fixes bug in SessionManager,where you replace
#XXXwith the appropriate GitHub issue. Best practiceis to use the GitHub issue title in the pull request title and in the first line of the commit message.
fixes #XXXif merging the PR should close a related issue.mvn verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like
[DOC] - Add javadoc in SessionManager.If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.